Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): extract properties from extended collections #9854

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

posva
Copy link
Member

@posva posva commented Dec 16, 2023

Fix #9852

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

Copy link

codspeed-hq bot commented Dec 16, 2023

CodSpeed Performance Report

Merging #9854 will not alter performance

Comparing fix/extends-collection-types (350ceb3) with main (04d2c05)

Summary

✅ 53 untouched benchmarks

@posva
Copy link
Member Author

posva commented Dec 16, 2023

It's worth noting we still have this issue:

  class ExtendendSet1 extends Set<{ wrap: Ref<number> }> {
    foo = ref('foo')
    bar = 1
  }

  const eset2 = ref(new ExtendendSet1())

  // ts error
  eset2.value = new ExtendendSet1()

This is the same with ref({ a: ref(0) }) not allowing setting the value to { a: ref(1 }

@yyx990803 yyx990803 merged commit 24b1c1d into main Dec 19, 2023
18 checks passed
@yyx990803 yyx990803 deleted the fix/extends-collection-types branch December 19, 2023 09:05
zhangenming added a commit to zhangenming/vue-next that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for classes extending Maps or Set "lose" methods/properties added in those classes after unwrapping
2 participants